allow custom filenaming #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
requested changes
Mar 4, 2024
adafruit_pycamera/__init__.py
Outdated
Comment on lines
830
to
833
| filename = "/sd/img%04d.%s" % (self._image_counter, extension) | ||
| filename = f"/sd/{filename_prefix}%04d.%s" % ( | ||
| self._image_counter, | ||
| extension, | ||
| ) |
There was a problem hiding this comment.
I'd like you to revise this so that it's just one formatting operation. It'd be something like f"/sd/{filename_prefix}{image_counter:04d}.{extension}", I think.
There was a problem hiding this comment.
The latest commits change that to use a single format operation. It turns out my IDEs code formatter also unintentionally broke the example by splitting a long line string across multiples so I fixed that with .format()
jepler
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to pass a custom string to get used instead of the default "img" in the photo filenames.
It will still include the 4 digit integer counter for ensuring unique names.
resolves #17