Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use espcamera reset functionality; other minor changes #41

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

dhalbert
Copy link
Contributor

  • espcamera knows how to toggle the power and reset pins to do a reset. Let it do it instead of doing it in Python code.
  • Make docstring be one string
  • use I2C write_then_readinto()

I made these changes while debugging ESP-IDF new I2C driver support.

- espcamera knows how to toggle the power and reset pins to do a reset. Let it do it.
- Make docstring be one string
- use I2C write_then_readinto
Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks!

@dhalbert dhalbert merged commit e263dad into adafruit:main Sep 29, 2024
1 check passed
@dhalbert dhalbert deleted the use-builtin-reset branch September 29, 2024 17:36
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 30, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.4.1 from 8.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#213 from dhalbert/zap-file
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#212 from dhalbert/wsgi-server-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#41 from dhalbert/use-builtin-reset

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants