msd demo improvements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* detect media when initially booted * track removal via loss of index (needed for my PC Jr drive) * remove a bunch of debug prints * fix display of "dirty"/"clean" status * allow read-back of IDAM track number * allow writing an MFM track with a specific logical track number (instead of always following the physical track number), needed for 360KiB media in 1200KiB-capable drives * eliminate some stack'd buffers * use nullptr in place of NULL in some locations * fix an item that should have been a static constexpr but was not
|
This now works with 360KiB media in my 5.25 DSHD drive. It isn't working in my 360KiB-only drive but I think that's the hardware's fault. |
|
@ladyada ready for your review :) |
ladyada
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(instead of always following the physical track number), needed for
360KiB media in 1200KiB-capable drives