Only include wiring_private.h if it exists (Arduino UNO R4 support) #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the new Arduino cores do not include this file. This includes the cores for the Arduino UNO Rev 4. Two ways to fix this. 1) add it specifically to a list of cores to not include it, like this file has #ifndef RASPI Or use GCC __has_include to detect it and then include it. With Arduino this will not work well for library headers, as the library search stuff will not see this as a dependency and as such won't add the -I to command line to find it. But this file is in core which is always on the search path
Used the indention of this that GCC example showed to use...
|
Do not want to causwe conflicts, but https://forum.arduino.cc/t/compilation-error-wiring-private-h-no-such-file-or-directory/1146752/2 |
Then include it. As suggested
|
Sounds good... |
mpechner
suggested changes
Sep 7, 2023
|
Closing out detritus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the new Arduino cores do not include this file. This includes the cores for the Arduino UNO Rev 4.
The change is limited to use the __has_include() preprocessor stuff be used to limit when arduino_private.h is included.
Two ways to fix this.
Or use GCC __has_include to detect it and then include it. With Arduino this will not work well for library headers, as the library search stuff will not see this as a dependency and as such won't add the -I to command line to find it. But this file is in core which is always on the search path
I ran this modified version on the UNO R4 Minima with the graphictest example.