Tweak passed arguments

adafruit · Oct 21, 2024 · 603f0c9 · 603f0c9
1 parent 5383f98
commit 603f0c9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/components/analogIO/Wippersnapper_AnalogIO.cpp b/src/components/analogIO/Wippersnapper_AnalogIO.cpp
@@ -325,7 +325,7 @@ bool Wippersnapper_AnalogIO::encodePinEvent(
 */
 /**********************************************************/
 void calculateHysteresis(analogInputPin pin, uint16_t pinValRaw,
-                         uint16_t pinValThreshHi, uint16_t pinValThreshLow) {
+                         uint16_t *pinValThreshHi, uint16_t *pinValThreshLow) {
   // All boards ADC values scaled to 16bit, in future we may need to
   // adjust dynamically
   uint16_t maxDecimalValue = 65535;
@@ -344,8 +344,8 @@ void calculateHysteresis(analogInputPin pin, uint16_t pinValRaw,
   }
 
   // get the threshold values for previous pin value
-  pinValThreshHi = pin.prvPinVal + CURRENT_HYSTERISIS;
-  pinValThreshLow = pin.prvPinVal - CURRENT_HYSTERISIS;
+  *pinValThreshHi = pin.prvPinVal + CURRENT_HYSTERISIS;
+  *pinValThreshLow = pin.prvPinVal - CURRENT_HYSTERISIS;
 }
 
 /**********************************************************/
@@ -425,8 +425,8 @@ void Wippersnapper_AnalogIO::update() {
 
         // check if pin value has changed enough
         uint16_t pinValThreshHi, pinValThreshLow;
-        calculateHysteresis(_analog_input_pins[i], pinValRaw, pinValThreshHi,
-                            pinValThreshLow);
+        calculateHysteresis(_analog_input_pins[i], pinValRaw, &pinValThreshHi,
+                            &pinValThreshLow);
         WS_DEBUG_PRINT("Returned pinValThreshHi: ");
         WS_DEBUG_PRINTLN(pinValThreshHi);
         WS_DEBUG_PRINT("Returned pinValThreshLow: ");

diff --git a/src/components/analogIO/Wippersnapper_AnalogIO.h b/src/components/analogIO/Wippersnapper_AnalogIO.h
@@ -57,8 +57,6 @@ class Wippersnapper_AnalogIO {
                   int pin);
   void disableAnalogInPin(int pin);
 
-  void calculateHysteresis(analogInputPin pin, uint16_t pinValRaw,
-                           uint16_t pinValThreshHi, uint16_t pinValThreshLow);
   uint16_t getPinValue(int pin);
   float getPinValueVolts(int pin);