Switch Analog Voltage on esp32 to use analogReadMilliVolts #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
force-pushed
the
use-analogReadMilliVolts-for-esp32
branch
3 times, most recently
from
781126c
to
708f830
Compare
tyeth
commented
Aug 23, 2024
tyeth
commented
Aug 23, 2024
|
note to self, retest this theory: |
tyeth
force-pushed
the
use-analogReadMilliVolts-for-esp32
branch
2 times, most recently
from
032817e
to
e900f61
Compare
|
This is superseded by #635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having issues with the C6 (set aVref to 1.1v and got 0.48v from 3v3 signal).
Just wanted to look into attenuation and the aVref, but saw that analogReadMilliVolts returned the calibrated millivolts, rather than the raw adc value which is uncalibrated.
This PR now switches both periodic and on_change to use the same functions, along with using analogReadMilliVolts for ESP32 based boards.