Add ruhrohrotaryio for non-sequential pin rotaryio use on rp2040 et al #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Oct 16, 2023
.gitmodules
Outdated
| @@ -391,3 +391,6 @@ | |||
| [submodule "libraries/drivers/at24mac_eeprom"] | |||
| path = libraries/drivers/at24mac_eeprom | |||
| url = https://github.com/facts-engineering/CircuitPython_AT24MAC_EEPROM.git | |||
| [submodule "libraries/drivers/ruhrohrotaryio"] | |||
| path = libraries/drivers/ruhrohrotaryio | |||
| url = [email protected]:todbot/CircuitPython_Community_Bundle.git | |||
There was a problem hiding this comment.
I think the url here needs to be https:// instead of git@ and this URL is pointing back to a fork of the Bundle rather than then new sub-project.
I think this URL should be:
https://github.com/todbot/CircuitPython_RuhRohRotaryIO.git
There was a problem hiding this comment.
oh! let me try, thank you
|
alright let me start all over again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rotaryio on at least RP2040 boards requires sequential GPIO pins which is confusing on, say, the QTPy RP2040 where pins seemingly next to each other like TX & SCL are not actually GPIO sequential. This little "fake rotaryio" driver acts like rotaryio but lets you any two pins.