Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chime module #191

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Move chime module #191

merged 2 commits into from
Oct 18, 2023

Conversation

FoamyGuy
Copy link
Contributor

resolves #190

I removed and then re-added the chime module under libraries/helpers

@CedarGroveStudios
Copy link
Contributor

Thank you!

@CedarGroveStudios
Copy link
Contributor

I just re-released the library to see if that helps this PR pass tests.

@FoamyGuy
Copy link
Contributor Author

@CedarGroveStudios thank you! looks like that did the trick 🎉

@CedarGroveStudios
Copy link
Contributor

CedarGroveStudios commented Oct 18, 2023

Excellent. I’ll also submit an issue with cookiecutter to suggest replacing the folder input with a binary choice to prevent inadvertent typos of the folder name.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 95327c7 into adafruit:main Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chime Library was moved to a newly created folder rather than libraries/helpers
3 participants