Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML library #196

Merged
merged 2 commits into from
Nov 23, 2023
Merged

TOML library #196

merged 2 commits into from
Nov 23, 2023

Conversation

elpekenin
Copy link
Contributor

As per title, library to read/dump data on TOML format. Is not fully compliant with the specification (doesn't aim for it anyway), but may come handy to work with data coming from the outside world or if a user wants something on settings.toml other than strings and integers

Let me know if i did something wrong (either on the PR itself or the repo's structure) and i will fix ASAP :)

@tannewt
Copy link
Member

tannewt commented Nov 17, 2023

Looks like you need to make a release in your repo. That way it can find a tag for the commit.

@elpekenin
Copy link
Contributor Author

elpekenin commented Nov 18, 2023

make a release

I did (i believe): https://github.com/elpekenin/circuitpython_toml/releases/tag/0.1.3

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't match the commit in this submodule (it is 5d6168 instead of ff1f4cd.)

@elpekenin
Copy link
Contributor Author

Oops, thanks for the catch. Should i pull the tag or just the main branch?

@tannewt
Copy link
Member

tannewt commented Nov 21, 2023

Oops, thanks for the catch. Should i pull the tag or just the main branch?

The bundle uses the latest tag.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FoamyGuy FoamyGuy merged commit 5cecb34 into adafruit:main Nov 23, 2023
1 check passed
@elpekenin elpekenin deleted the lib/toml branch November 23, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants