Update RH_RF69.cpp #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to use interrupt on DIO1 and debugged the loss of my setting to these blocks of code. In cases where only part of a byte of control values is being modified, the polite action is to mask only the bits being changed and avoid modifying other values that are not of interest.
|
heya im about to take a look at this PR, do you have an example of using DIO1 as an interrupt? i'm curious how i could test that this PR works :) a simple demo is best i fyou have one! |
|
Hi!
I am still tinkering with the feather to be sure that DIO1 is doing what's advertised in the SX1231 datasheet.
I am not detecting pulses on it when a packet arrives and now I need to hook it up to a scope and make sure I'm setting it all up correctly.
I'd say that for the majority of people buying the feather, the DIO1 issue isn't really going to matter much. So my suggested mod might not be time critical.
If you're willing to wait for me to fully debug this, I could share what I find and any code mods needed that I found as corrections. It might be a few weeks, though.
Thank you for responding!
Jonathan
Jonathan Halderman
From: ladyada
Sent: Monday, July 24, 21:40
Subject: Re: [adafruit/RadioHead] Update RH_RF69.cpp (#1)
To: adafruit/RadioHead
Cc: Jonathan Halderman, Author
heya im about to take a look at this PR, do you have an example of using DIO1 as an interrupt? i'm curious how i could test that this PR works :) a simple demo is best i fyou have one!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AcbZPETJUHKzicXZvjXAXQQgZwsKuhy_ks5sRXG-gaJpZM4OLNCy>.
|
|
ok sounds like a plan. we will wait till you get DIO1 working before merging! thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to use interrupt on DIO1 and debugged the loss of my setting to these blocks of code.
In cases where only part of a byte of control values is being modified, the polite action is to mask only the bits being changed and avoid modifying other values that are not of interest.