Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Arduino Pi Pico platform. #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PaulMartinsen
Copy link

Support for testing examples against the Arduino Pi Pico was added by extending the ALL_PLATFORMS collection in build_platforms.py. The new key, pi_pico, was added to main_platforms so it is included by default. Tested by running the tests on our Arduino library.

@tekktrik tekktrik self-requested a review May 20, 2023 00:53
@ladyada
Copy link
Member

ladyada commented Jun 26, 2023

please remove frmo 'main_platforms' - that means something special for our libraries and we dont want to add this board to our default :)

@PaulMartinsen
Copy link
Author

Done. Thanks for creating this; it has been very helpful.

Would you consider a PR that read the platforms to test from a file in the repository being tested, with fallback to main_platforms if file wasn't present?

@brentru
Copy link
Member

brentru commented Sep 12, 2023

@PaulMartinsen Hi - going through this repo and noticed this PR hasn't been resolved. It looks almost ready to me:

There are now a number of pico rp2040 platforms added which use the Philhower core. Could you add the mbed core underneath these and mention me when done?

@tekktrik tekktrik removed their request for review March 21, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants