-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now checks for branch before pushing #80
base: master
Are you sure you want to change the base?
Conversation
You might consider programmatically determining the name of the default branch, rather than hardcoding them. It's already possible to pick whichever default branch name you like and we might see an increase in diversity in the default branch names as people use their own preferences when renaming the existing branches named There is an example of checking the default branch name in a Bash script here: It does use some GitHub Actions-specific environment variables:
|
@per1234 Thanks for linking that. I'm doing a release sweep right now, but I'll integrate that into my script when I'm done |
@per1234 Thanks! Looks like it's working. Now I've just got to get travis to pass |
Well... That's odd. Not quite sure how this could fail on test platforms |
Ah, looks like that's been happening for a while. New CI runs https://github.com/adafruit/Adafruit_BMP183_Library/runs/858256947 |
Just putting a reminder here to release bmp183 after this gets merged |
@evaherrada - is this still needed and/or relevant? If we've gotten along so far without this, is it worth pursuing still? |
Tested on BMP183.
In this case, we were on master and there were changes to commit, so it committed and pushed them to gh-pages.
https://github.com/adafruit/Adafruit_BMP183_Library/runs/855278911?check_suite_focus=true#step:8:13
In this case we are on the branch I made to make the test PR from. As expected, it does not push to gh-pages
https://github.com/adafruit/Adafruit_BMP183_Library/runs/855291221?check_suite_focus=true#step:8:13