Skip to content

use python 3.12 to build docs #10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

FoamyGuy
Copy link
Collaborator

This should let us work around: adafruit/Adafruit_Blinka#974 for now.

The hope is that eventually lgpio will get updated to be installable via pip under py3.13 and then should be able to go back to it.

@FoamyGuy
Copy link
Collaborator Author

I think we are going to need this change inside of RTD config inside of libraries as well.

The library github actions docs build are centralized in the workflows repo and are already set to 3.12, but the RTD ones are individual in each repo and are set to 3 currently. i.e. https://github.com/adafruit/Adafruit_CircuitPython_Display_Text/blob/7d1f187aac8e899e791324cc78633bf4f32c984b/.readthedocs.yaml#L17

I will try to validate this and work on a patch for adabot if this is the case.

@FoamyGuy
Copy link
Collaborator Author

I think I found a potentially better solution than this actually. Testing a few things and then will post more details if it works out.

@dhalbert
Copy link
Collaborator

I think we are going to need this change inside of RTD config inside of libraries as well.

Can you avoid this if the lgpio build is done by hand, or does it also affect the building of any library that requires Blinka?

There is a cascade of changes happening to fix one problem. We could also build a 3.13 wheel ourselves (maybe we need to "fork" lgpio for now).

@FoamyGuy
Copy link
Collaborator Author

@dhalbert this is an alternative solution I think: adafruit/Adafruit_Blinka#977

I didn't know that requirements.txt could contain conditions on python versions like this, but found other usages of that in blinkas requirements file.

That change seems to allow the adafruit-blinka install to succeed under py3.13, without needing lgpio. I think it should still be able to complete a docs build like this but am still in the process of testing that.

@FoamyGuy
Copy link
Collaborator Author

Okay I was able to successfully build docs for a library, as well as docs and stubs for the core inside of a container with py3.13 using the version of Blinka from adafruit/Adafruit_Blinka#977

I think that is a better solution than changing the config to use 3.12, going to close this. But can re-open if more discussion needed.

@FoamyGuy FoamyGuy closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants