Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Italian translation #1235

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Add Italian translation #1235

merged 1 commit into from
Oct 9, 2018

Conversation

platipo
Copy link

@platipo platipo commented Oct 4, 2018

Adding draft, it needs to be reviewed.
Anyway I managed to translate all strings but 58 that I couldn't found a fitting expression so I let those blank.

See #1226.

@dhalbert
Copy link
Collaborator

dhalbert commented Oct 6, 2018

Could you merge the latest and run make translate again? Build is failing with "message message ID".

@platipo
Copy link
Author

platipo commented Oct 7, 2018

I rebased the commit and run make check-translate and make translations, neither of them raised errors on my computer

@platipo
Copy link
Author

platipo commented Oct 7, 2018

It seemed that when I started the translation there was an extra line

#: ports/nrf/common-hal/busio/SPI.c:170
msgid "Baud rate too high for this SPI peripheral"
msgstr "Baudrate troppo alto per questa periferica SPI"

And the script detected only the difference between the two, wouldn't it be more informative to do just:

for trans in $(ls locale/*.po); do
    diff <(grep "^msgid" locale/circuitpython.pot) <(grep "^msgid" $trans)
done

@tannewt
Copy link
Member

tannewt commented Oct 8, 2018

Great job translating all of these messages! Leaving some blank is fine. This is a great start.

Looks like the build is failing due to a missing line ending: https://travis-ci.org/adafruit/circuitpython/jobs/438210422#L711

I don't think the diff command will find all cases because msgids can wrap on multiple lines. The python script should be able to detect it though.

Adding first draft, it needs to be reviewed
@platipo
Copy link
Author

platipo commented Oct 9, 2018

Fixed missing newlines and ready to merge.

Maybe the diff could improve by improving the regex, but I think that the check-translate script should me more informative because it's easy to miss one line in 500+ msgids

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you!

@tannewt tannewt merged commit e9aefcc into adafruit:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants