-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated highlightjs to v9.0.9 #403
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to fix it up, since the Mozilla store does not allow minified version of the highlight.js file....
Okay, now it's updated to use the non minified version |
See #402 |
@ickc this is to solve the request to update it, it's not a issue but it's a PR |
Fixes #408 |
Fixes #414 |
@adam-p Attached is v9.12.0 with the |
@adam-p Would you prefer an update to this pr or a new pr instead? This issue is a longstanding one and your extension relies upon |
Kotlin seems not working in the current version, checked https://github.com/adam-p/markdown-here/blob/master/src/common/highlightjs/highlight.js and cannot find registerLanguage for Kotlin also. Is there some else needed to do to support Kotlin? |
Finally I have solved these problem. For people need kotlin heighlight & weixin open platform style support can use the code here https://github.com/shenguojun/markdown-here |
Updated the highlight.js library to the v9.0.9 version that allows for more language support like Julia. Also updated the tests as some of the library changes the markup a little, namely with a wrapper. I tested with Chrome only but I don't think that it should have a major effect on the other parts of the library. This is in response to another issue that was brought up a bit ago and since it was quick to do: #402