Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated highlightjs to v9.0.9 #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

daemedeor
Copy link

@daemedeor daemedeor commented Jan 8, 2017

Updated the highlight.js library to the v9.0.9 version that allows for more language support like Julia. Also updated the tests as some of the library changes the markup a little, namely with a wrapper. I tested with Chrome only but I don't think that it should have a major effect on the other parts of the library. This is in response to another issue that was brought up a bit ago and since it was quick to do: #402

Copy link
Author

@daemedeor daemedeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to fix it up, since the Mozilla store does not allow minified version of the highlight.js file....

@daemedeor
Copy link
Author

Okay, now it's updated to use the non minified version

@ickc
Copy link

ickc commented Jan 9, 2017

See #402

@daemedeor
Copy link
Author

@ickc this is to solve the request to update it, it's not a issue but it's a PR

@ickc
Copy link

ickc commented Jan 9, 2017

I mean to cross reference it to #402, since your original comment has a typo that reference to #403. I was just lazy so I didn't write this (and I see you already corrected your typo)

@jrappen
Copy link

jrappen commented May 30, 2017

Fixes #408

@jrappen
Copy link

jrappen commented May 30, 2017

Fixes #414

@jrappen
Copy link

jrappen commented Oct 27, 2017

@adam-p Attached is v9.12.0 with the styles.json updated accordingly.

highlightjs-v9-12-0.zip

@jrappen
Copy link

jrappen commented Nov 10, 2017

@adam-p Would you prefer an update to this pr or a new pr instead? This issue is a longstanding one and your extension relies upon highlight.js for syntax highlighting. It would be great to have the extension updated with a newer version of highlight.js which supports more languages.

@shenguojun
Copy link

Kotlin seems not working in the current version, checked https://github.com/adam-p/markdown-here/blob/master/src/common/highlightjs/highlight.js and cannot find registerLanguage for Kotlin also. Is there some else needed to do to support Kotlin?

@shenguojun
Copy link

Finally I have solved these problem. For people need kotlin heighlight & weixin open platform style support can use the code here https://github.com/shenguojun/markdown-here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants