Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zfs/en-en] Update zfs.html.markdown #4817

Merged
merged 10 commits into from
May 13, 2024
Merged

Conversation

81reap
Copy link
Contributor

@81reap 81reap commented Dec 31, 2023

  • Changes VDEV types into a table

  • Adds ZFS Write Log Section

  • Adds ZFS Read Log Section

  • Adds ZFS Compression Section

  • Adds ZFS Encryption Section

  • I solemnly swear that this is all original content of which I am the original author

  • Pull request title is prepended with [language/lang-code] (example [python/fr-fr] or [java/en])

  • Pull request touches only one file (or a set of logically related files with similar changes made)

  • Content changes are aimed at intermediate to experienced programmers (this is a poor format for explaining fundamental programming concepts)

  • If you've changed any part of the YAML Frontmatter, make sure it is formatted according to CONTRIBUTING.md

    • Yes, I have double-checked quotes and field names!

- Changes VDEV types into a table
- Adds ZFS Write Log Section
- Adds ZFS Read Log Section
- Adds ZFS Compression Section
- Adds ZFS Encryption Section
- adds contributor
- fixes format to fix repo
fixes encryption section
@81reap
Copy link
Contributor Author

81reap commented Dec 31, 2023

Okay the PR is good to be looked at. What should I do about the translated pages? I don't know those languages but I can chatgpt it.

changes encryption perspective to be as if you are just setting up the pool. makes more sense this way
fix titles to match format
@81reap
Copy link
Contributor Author

81reap commented Jan 14, 2024

@sarlalian would you be able to take a look at this PR?

zfs.html.markdown Outdated Show resolved Hide resolved
81reap and others added 2 commits April 6, 2024 20:31
update the call to check for zfs encryption.

Co-authored-by: A1EF <[email protected]>
@81reap
Copy link
Contributor Author

81reap commented Apr 7, 2024

@A1EF would you be able to approve and/or merge these changes?

@A1EF
Copy link
Contributor

A1EF commented Apr 7, 2024

Sorry I haven't privileges for that but I think @vendethiel can help.

zfs.html.markdown Outdated Show resolved Hide resolved
@verhovsky verhovsky requested a review from A1EF April 19, 2024 06:58
@verhovsky verhovsky merged commit bd36d77 into adambard:master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants