-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zfs/en-en] Update zfs.html.markdown #4817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes VDEV types into a table - Adds ZFS Write Log Section - Adds ZFS Read Log Section - Adds ZFS Compression Section - Adds ZFS Encryption Section
- adds contributor - fixes format to fix repo
fixes encryption section
Okay the PR is good to be looked at. What should I do about the translated pages? I don't know those languages but I can chatgpt it. |
changes encryption perspective to be as if you are just setting up the pool. makes more sense this way
fix titles to match format
@sarlalian would you be able to take a look at this PR? |
A1EF
reviewed
Mar 24, 2024
update the call to check for zfs encryption. Co-authored-by: A1EF <[email protected]>
@A1EF would you be able to approve and/or merge these changes? |
Sorry I haven't privileges for that but I think @vendethiel can help. |
A1EF
reviewed
Apr 7, 2024
Co-authored-by: A1EF <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes VDEV types into a table
Adds ZFS Write Log Section
Adds ZFS Read Log Section
Adds ZFS Compression Section
Adds ZFS Encryption Section
I solemnly swear that this is all original content of which I am the original author
Pull request title is prepended with
[language/lang-code]
(example[python/fr-fr]
or[java/en]
)Pull request touches only one file (or a set of logically related files with similar changes made)
Content changes are aimed at intermediate to experienced programmers (this is a poor format for explaining fundamental programming concepts)
If you've changed any part of the YAML Frontmatter, make sure it is formatted according to CONTRIBUTING.md