Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Fix failing Python tests #674

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GitHub Actions: Fix failing Python tests #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67626bc
GitHub Actions: Fix failing Python tests
cclauss Mar 16, 2024
febbf13
GitHub Actions: Fix failing Python tests
cclauss Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: [3.8, 3.9, "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]

steps:
- uses: actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion django_unicorn/components/unicorn_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def __init__(self, component_args: Optional[List] = None, **kwargs):
if not self.component_name:
raise AssertionError("Component name is required")

if "id" in kwargs and kwargs["id"]:
if kwargs.get("id"):
# Sometimes the component_id is initially in kwargs["id"]
self.component_id = kwargs["id"]

Expand Down
Loading