Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test utils] sort file tree entries (so it's stable across OSes) #138

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jan 15, 2024

Also, use 'shouldBeEqual' for string comparison (using 'shouldBe' shows quotes around expected/actual)

@aSemy aSemy enabled auto-merge January 15, 2024 09:47
@aSemy aSemy disabled auto-merge January 15, 2024 11:45
@aSemy aSemy force-pushed the fix/stable-filetree-order branch 2 times, most recently from 414d5e7 to f0faf9c Compare January 16, 2024 16:27
@aSemy
Copy link
Contributor Author

aSemy commented Jan 16, 2024

Am I going insane? Why is the test on Ubuntu running an outdated test??? The tree comparison test doesn't exist any more!

image

UPDATE: I wasn't going insane, the GHA Workflows were bugged so they didn't checkout the current ref - they checked out the main branch! They've been broken for months, none of the PRs have been tested. Hopefully fixed with #140

@aSemy aSemy force-pushed the fix/stable-filetree-order branch from b486138 to cf6464b Compare January 16, 2024 20:17
@aSemy aSemy added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 8835896 Jan 16, 2024
4 checks passed
@aSemy aSemy deleted the fix/stable-filetree-order branch January 16, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant