Skip to content

Commit

Permalink
Fix improper handling of time.Duration type
Browse files Browse the repository at this point in the history
  • Loading branch information
adamkpickering committed Feb 4, 2023
1 parent c846b43 commit 80cd78b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions internal/scheduler/two_review.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,17 @@ func (scheduler *TwoReviewScheduler) GetNextReview(card *models.Card) (time.Time
}

if reviews[0].Result == models.Failed {
interval := scheduler.config.FailedReviewInterval * uint(time.Hour)
return reviews[0].Datetime.Add(time.Duration(interval)), nil
interval := time.Duration(scheduler.config.FailedReviewInterval) * time.Hour
return reviews[0].Datetime.Add(interval), nil
}

if reviewsLength == 1 || (reviewsLength == 2 && reviews[1].Result == models.Failed) {
intervalInHours, err := getSecondReviewIntervalFor(reviews[0].Result, scheduler.config)
if err != nil {
return time.Time{}, fmt.Errorf("failed to get second review interval: %w", err)
}
interval := intervalInHours * uint(time.Hour)
return reviews[0].Datetime.Add(time.Duration(interval)), nil
interval := time.Duration(intervalInHours) * time.Hour
return reviews[0].Datetime.Add(interval), nil
}

lastReview := reviews[0]
Expand Down

0 comments on commit 80cd78b

Please sign in to comment.