Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 2 vulnerabilities #1053

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

adamlaska
Copy link
Owner

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • packages/order-utils/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 701/1000
Why? Recently disclosed, Has a fix available, CVSS 8.3
Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8172694
Yes No Known Exploit
high severity 828/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 8.7
Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8187303
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @0x/dev-utils The new version differs by 193 commits.

See the full diff

Package name: @0x/subproviders The new version differs by 15 commits.

See the full diff

Package name: @0x/utils The new version differs by 115 commits.

See the full diff

Package name: web3-provider-engine The new version differs by 193 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Copy link

google-cla bot commented Oct 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@0x/[email protected] filesystem, shell Transitive: environment, network +30 8.9 MB tobernguyen
npm/@0x/[email protected] Transitive: environment, eval, network +45 12.9 MB dorothy-zbornak
npm/@0x/[email protected] Transitive: environment, eval, network +48 20.2 MB tobernguyen
npm/@0x/[email protected] Transitive: environment, network +21 8.61 MB dorothy-zbornak
npm/@0x/[email protected] Transitive: environment, eval, network +45 18.4 MB tobernguyen
npm/@0x/[email protected] None 0 613 kB dorothy-zbornak
npm/@0x/[email protected] Transitive: environment, network +21 8.17 MB dorothy-zbornak
npm/@0x/[email protected] Transitive: environment, filesystem, network +22 7.81 MB tobernguyen
npm/@0x/[email protected] environment Transitive: eval, filesystem, network +71 75 MB tobernguyen
npm/@0x/[email protected] Transitive: environment, eval, network +45 17.5 MB tobernguyen
npm/@0x/[email protected] environment, filesystem Transitive: eval, network, shell +92 27.7 MB dorothy-zbornak
npm/@0x/[email protected] Transitive: environment, eval, network +27 9.15 MB dorothy-zbornak
npm/@0x/[email protected] environment, filesystem, network, shell Transitive: eval +33 9.38 MB tobernguyen
npm/@0x/[email protected] filesystem Transitive: environment, network +35 10.4 MB fberger
npm/@0x/[email protected] None +1 758 kB dekz
npm/@0x/[email protected] None +2 1.15 MB dekz
npm/@0x/[email protected] None +5 2.85 MB dekz
npm/@0x/[email protected] network Transitive: environment +22 8.35 MB dorothy-zbornak
npm/@0x/[email protected] Transitive: environment, eval, network +26 8.95 MB dorothy-zbornak
npm/[email protected] None +1 42.6 kB chaijs
npm/[email protected] None +3 789 kB chaijs
npm/[email protected] None 0 20.3 kB joshperry
npm/[email protected] None +2 1.11 MB dekz

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎
Git dependency npm/[email protected] ⚠︎
Protestware or potentially unwanted behavior npm/[email protected]
  • Note: The script attempts to run a local post-install script, which could potentially contain malicious code. The error handling suggests that it is designed to fail silently, which is a common tactic in malicious scripts.
⚠︎
Protestware or potentially unwanted behavior npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What are git dependencies?

Contains a dependency which resolves to a remote git URL. Dependencies fetched from git URLs are not immutable can be used to inject untrusted code or reduce the likelihood of a reproducible install.

Publish the git dependency to npm or a private package repository and consume it from there.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants