Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2024

dont merge

includes initialization of cursor moving functionality from #29 , and fully implements it

closes #29

@ghost ghost requested a review from adamperkowski as a code owner November 9, 2024 11:22
@ghost
Copy link
Author

ghost commented Nov 9, 2024

#34 needs to be reworked,

        self.buffer.chars[BUFFER_HEIGHT - 1][self.column_position].write(ScreenChar {
            ascii_character: b' ',
            color_code: self.color_code,
        });

will not work properly here.

@ghost ghost marked this pull request as draft November 9, 2024 11:25
@ghost ghost changed the title Cursor moving init implement cursor moving functionality Nov 9, 2024
@ghost
Copy link
Author

ghost commented Nov 9, 2024

#34 needs to be reworked,

        self.buffer.chars[BUFFER_HEIGHT - 1][self.column_position].write(ScreenChar {
            ascii_character: b' ',
            color_code: self.color_code,
        });

will not work properly here.

disregard this, fixed in a20603c

@ghost
Copy link
Author

ghost commented Jan 7, 2025

ded

@ghost ghost closed this Jan 7, 2025
@ghost ghost deleted the cursor_moving_init branch January 7, 2025 09:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants