Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add is-optional and is-complete classes to each PLP item (fixes #203) #204

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix: Add is-optional and is-complete classes to each PLP item (fixes #203) #204

merged 1 commit into from
Feb 9, 2024

Conversation

swashbuck
Copy link
Contributor

Fix #203

Fix

  • Adds is-optional and is-complete classes to each page level progress item

Testing

  1. Set a component to optional with "_isOptional": true
  2. Complete a different component
  3. Check that the new classes are applied to the appropriate pagelevelprogress__item-btn element.

@swashbuck swashbuck self-assigned this Feb 8, 2024
guywillis
guywillis approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit ea05914 into master Feb 9, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/203 branch February 9, 2024 13:35
github-actions bot pushed a commit that referenced this pull request Feb 9, 2024
@semantic-release-bot
Chore(release): 7.3.1 [skip ci]
5d7364a 
## [7.3.1](v7.3.0...v7.3.1) (2024-02-09)

### Fix

* Add is-optional and is-complete classes to each PLP item (#204) ([ea05914](ea05914)), closes [#204](#204)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 7.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional and complete classes to items
4 participants
@swashbuck @guywillis @cahirodoherty-learningpool @joe-allen-89