Update: display padlock for locked items (fixes #209)

[kirsty-hames]

Fixes #209

Update

As per adaptlearning/adapt-contrib-vanilla#446, locked buttons should display a padlock icon.

I considered whether the padlock icon should replace the progress indicator when locked but for now decided to keep this as supplementary.

Note, the addition of `.pagelevelprogress__item-icon` could be later used to replace progress bars with icons as per #181.

[joe-allen-89]

👍

[swashbuck]

I considered whether the padlock icon should replace the progress indicator when locked but for now decided to keep this as supplementary.

@kirsty-hames I prefer only showing the lock icon instead of both the lock icon and (nearly) empty progress bar.

1. The progress bar will always essentially be at zero percent for locked items, so it does not serve much purpose.
2. It is cleaner with only the locked icon or the progress bar (not both). Having both also reduces the amount of space you have for the title before the text wraps.

The only drawback is that you won't see "optional content" unless the item has been unlocked, but not sure how important that is? Curious if others agree.

[kirsty-hames]

I considered whether the padlock icon should replace the progress indicator when locked but for now decided to keep this as supplementary.

@kirsty-hames I prefer only showing the lock icon instead of both the lock icon and (nearly) empty progress bar.

1. The progress bar will always essentially be at zero percent for locked items, so it does not serve much purpose.
2. It is cleaner with only the locked icon or the progress bar (not both). Having both also reduces the amount of space you have for the title before the text wraps.

Thanks @swashbuck. I agree with your points and this would also be my preference.

The only drawback is that you won't see "optional content" unless the item has been unlocked, but not sure how important that is? Curious if others agree.

.pagelevelprogress__item-optional is rendered separately to .pagelevelprogress__indicator so it's possible to display both the lock icon and "optional content". See screenshot below. Changes committed in e160cd5.

[swashbuck]

👍 Looks and works great!

[cahirodoherty-learningpool]

👀

[github-actions]

🎉 This PR is included in version 7.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀