more robust table extraction #767
Conversation
fix type check
unsleepy22
force-pushed
the
refine-table-extraction
branch
from
a42df23 to
c510ac5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 21 21
Lines 3576 3587 +11
=======================================
+ Hits 3550 3561 +11
Misses 26 26 ☔ View full report in Codecov by Sentry. |
|
@unsleepy22 Thanks for the PR, everything looks OK to me but the code could be improved using the suggestions above. |
Thanks for your comments, updated accordingly, would you take a look again? |
trafilatura/utils.py
Outdated
|
|
||
| def is_in_table_cell(elem: _Element) -> bool: | ||
| '''Check whether an element is in a table cell''' | ||
| return elem.xpath('//ancestor::cell') |
There was a problem hiding this comment.
@unsleepy22 The .xpath method returns a list of elements or [], the type annotation is not correct and since we don't need the list it's useless to return it, I suggest using return bool(elem.xpath(...)).
There was a problem hiding this comment.
Yes you're right, type check didn't find this one.
Refine table extraction and add more test cases.