-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure $ is available and keep the slidebars variable global #240
base: master
Are you sure you want to change the base?
Conversation
This works. Can confirm this makes Drupal play nicely. |
Works for WordPress as well! |
@gaswirth If you're interested, I've turned slidebars into a WP plugin. It already has this patch included. If you find any issues with themes, please let me know. (Though please read the installation instructions first :) ). |
Awesome, thanks! I've already integrated the patch into the theme I'm working on, but my next project I'll give your plugin a shot! Cheers! |
Hey @JoryHogeveen, thanks again for the plugin heads up. Works great! For my purposes, I'd still love to see this PR merged, as it works perfectly and it's easier for me to integrate Slidebars with my themes manually, and I miss being able to install with bower to keep everything up-to-date! |
Hi @gaswirth , no problem! I'm currently busy with a fearture update with a lot more hooks for both PHP and JS. It will also feature a first version of a simple API to echo your sidebars in your theme yourself. |
Love it. You rock! |
Thanks :) If you would like to help testing or have more ideas let me know! |
Why this fix is still not applied to latest version of master branch?... |
Works for me. Would like to see this merged. |
Works for me also, should be merged. Thanks. |
Just a quick thanks, I was so close to figuring this out myself, but didn't think to declare the var outside of the function, because I'm a JS noob. I also took the time to re-express slidebars as Slidebars, because jshint told me so when running gulp. |
Would be great if this could be merged to the stable version! |
Fixes #238