Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure $ is available and keep the slidebars variable global #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoryHogeveen
Copy link

Fixes #238

@JoryHogeveen JoryHogeveen mentioned this pull request Aug 7, 2016
JoryHogeveen added a commit to JoryHogeveen/off-canvas-sidebars that referenced this pull request Aug 7, 2016
@devkinetic
Copy link

This works. Can confirm this makes Drupal play nicely.

@gaswirth
Copy link

Works for WordPress as well!

@JoryHogeveen
Copy link
Author

@gaswirth If you're interested, I've turned slidebars into a WP plugin. It already has this patch included.
https://wordpress.org/plugins/off-canvas-sidebars/

If you find any issues with themes, please let me know. (Though please read the installation instructions first :) ).
https://wordpress.org/plugins/off-canvas-sidebars/installation/

@gaswirth
Copy link

Awesome, thanks! I've already integrated the patch into the theme I'm working on, but my next project I'll give your plugin a shot! Cheers!

@gaswirth
Copy link

Hey @JoryHogeveen, thanks again for the plugin heads up. Works great! For my purposes, I'd still love to see this PR merged, as it works perfectly and it's easier for me to integrate Slidebars with my themes manually, and I miss being able to install with bower to keep everything up-to-date!

@JoryHogeveen
Copy link
Author

JoryHogeveen commented Sep 16, 2016

Hi @gaswirth , no problem!
As for integration, it's possible to disable the plugin frontend and generate everything within you theme while using the config/setting features from the plugin.

I'm currently busy with a fearture update with a lot more hooks for both PHP and JS. It will also feature a first version of a simple API to echo your sidebars in your theme yourself.
Will start on a doc/wiki asap :)

See JoryHogeveen/off-canvas-sidebars#10

@gaswirth
Copy link

Love it. You rock!

@JoryHogeveen
Copy link
Author

Thanks :) If you would like to help testing or have more ideas let me know!

@wonsuc
Copy link

wonsuc commented Feb 6, 2017

Why this fix is still not applied to latest version of master branch?...
It is almost 6 months passed.

@Brugman
Copy link

Brugman commented Mar 17, 2017

Works for me. Would like to see this merged.

@5n00p4eg
Copy link

Works for me also, should be merged. Thanks.

@srjwebster
Copy link

Just a quick thanks, I was so close to figuring this out myself, but didn't think to declare the var outside of the function, because I'm a JS noob. I also took the time to re-express slidebars as Slidebars, because jshint told me so when running gulp.

@berlindave
Copy link

Would be great if this could be merged to the stable version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants