Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS for mobile browsers and various html/body targeting libraries #257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JoryHogeveen
Copy link

@JoryHogeveen JoryHogeveen commented Sep 29, 2016

Fixes: #251
Related: #292

Todo

  • Check animations (shift and reveal don't work correctly for top and bottom because z-index: 0;)
  • Check other options (example: disable site scrolling is not working with this fix when hovering over the sidebar)

@JoryHogeveen JoryHogeveen changed the title Fix CSS for mobile browsers Fix CSS for mobile browsers and various html/body targeting libraries Sep 30, 2016
@JoryHogeveen JoryHogeveen mentioned this pull request Oct 5, 2016
12 tasks
@JoryHogeveen JoryHogeveen mentioned this pull request Oct 14, 2016
@philippfrenzel
Copy link

philippfrenzel commented Mar 18, 2017

👍

@NoLooseEnds
Copy link

NoLooseEnds commented Sep 27, 2017

Thanks. This solved my issue #277

EDIT: Looks like it breaks smoothscroll to #anchors

    $( 'a[href^="#"]' ).on( 'click', function( event ) {
      event.preventDefault();

      var target = $( this ).attr( 'href' );

      $( '[canvas="container"]' ).animate( {
        scrollTop: $(target).offset().top,
      },
      700 );
    });

EDIT2: Looks like a more traditional smooth scroll approach works. :)

@JoryHogeveen
Copy link
Author

@NoLooseEnds
Yep this was meant for enable "normal" smooth scroll scripts again as well. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slidebars broke iOS & Chrome address bar auto-resize
3 participants