squid:S2095 - Resources should be closed

[georgekankava]

This pull request is focused on resolving occurrences of Sonar rule
squid:S2095 - Resources should be closed.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS2095
Please let me know if you have any questions.
George Kankava

[tea-dragon]

We're returning a Stream here -- it is kind of important that we don't close it prematurely. The javadoc also notes that the caller is responsible for closing it, and most importantly, no (non-fatal) exception can occur that leaves the file stream open. The IOException can only occur during the initial Files.list, and if it does, then it handles that cleanup internally.

[tea-dragon]

I made some notes on the code I am most familiar with, but from what I saw in other bits, there are some very reasonable changes. Certainly that AssetsResource class was definitely neglecting that FileInputStream. I'll see if I can get the respective authors to review the other changes, but you might end up having to make do with me again :)

Once again, we really appreciate the contribution. I hope my comments don't come off the wrong way.

[georgekankava]

Hi Ian,

Thank you for the PRs review and sorry that it took some time for you to
add comments.
With this PR you can just let me know which portions should be reverted and
I will leave only necessary ones.
I am looking forward to create some more PRs, maybe more simple ones for
this time.

Regards,
George

On Wed, Feb 10, 2016 at 11:48 AM, Ian Barfield [email protected]
wrote:

I made some notes on the code I am most familiar with, but from what I saw
in other bits, there are some very reasonable changes. Certainly that
AssetsResource class was definitely neglecting that FileInputStream. I'll
see if I can get the respective authors to review the other changes, but
you might end up having to make do with me again :)

Once again, we really appreciate the contribution. I hope my comments
don't come off the wrong way.

—
Reply to this email directly or view it on GitHub
#198 (comment).