#214: webpack migration #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on the migration to Webpack! Is there functionally anything missing from the move? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Addy,
This one looks way worse than it actually is. It's still a WIP but the site is functionally identical to the grunt build. I just wanted to make sure you are comfortable with what this migration will look like. I still need to minify CSS and HTML and add
webpack-dev-server.It was actually a pretty rough transition to webpack since the dependencies don't play nice with bundlers that do more than concat the JS files together. I tried several ways of shimming them in and this seemed to be the cleanest.
I also took out the tests since they weren't being used (and probably never will be).
See issue #214