Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionallity for deleting branches. #352

Merged
merged 6 commits into from
Apr 17, 2020
Merged

Conversation

maximAtanasov
Copy link
Member

@maximAtanasov maximAtanasov commented Apr 16, 2020

If a branch has been deleted in the remote repository, it will now also get deleted from the database.

Closes #347

deleteCommits(branchCommit, branchesInProject);
}

private void deleteCommits(CommitEntity commit, List<BranchEntity> branchesInProject) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add javadoc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Test
void testDeleteBranch() {
deleteBranchPort.delete(
projectId, new Branch("testBranch2", "fcd9a0e7c34086fdb0aedc82497f8ddfa142e961"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a member for the branch objects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@maximAtanasov maximAtanasov merged commit 19435bf into master Apr 17, 2020
@maximAtanasov maximAtanasov deleted the delete-branches branch April 17, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coderadar should delete branch nodes if the branch has been deleted in the remote repository.
2 participants