Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkshttp #760

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

checkshttp #760

wants to merge 12 commits into from

Conversation

jesusfcr
Copy link
Contributor

@jesusfcr jesusfcr commented Dec 4, 2024 •
edited
Loading

  • Split ARG to allow skaffold manage them
  • Remomve logger global variable
  • Use new http sdk
  • Update vulcan-check-sdk
  • Allow aws checks to use existing credentials without assumerole
  • Use CloneGitRepositoryContext to manage cancelations

@jesusfcr jesusfcr marked this pull request as ready for review December 10, 2024 08:17
seilagamo
seilagamo requested changes Dec 10, 2024
View reviewed changes
cmd/vulcan-trivy/vulcan-trivy.go Outdated Show resolved Hide resolved
@jesusfcr jesusfcr force-pushed the checkshttp branch 4 times, most recently from 1c0f6cf to f22403f Compare December 13, 2024 12:02
@jesusfcr jesusfcr requested a review from seilagamo December 16, 2024 13:33
@jesusfcr jesusfcr force-pushed the checkshttp branch 3 times, most recently from f449d7e to ba2f2b5 Compare December 19, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seilagamo seilagamo Awaiting requested review from seilagamo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesusfcr @seilagamo