Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oidc): make OIDC endpoint runtime configurable #444

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat(oidc): make OIDC endpoint runtime configurable #444

merged 1 commit into from
Dec 6, 2023

Conversation

trowik
Copy link
Member

@trowik trowik commented Dec 5, 2023

No description provided.

derrabauke
derrabauke reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@derrabauke derrabauke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work as intended. How do you plan to resolve sso-client-host to a valid fqdn?

Sorry, I've overseen the changes to the entrypoint script.

@derrabauke
Copy link
Contributor

We are keeping this in mind adfinis/timed#122 , but for now the proposed implementation in this PR is good enough. ;)

@trowik trowik merged commit a26d1eb into adfinis:main Dec 6, 2023
3 checks passed
@hairmare hairmare mentioned this pull request Dec 6, 2023
Merged
7 tasks
@adfinisbot
Copy link
Member

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabauke derrabauke derrabauke approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trowik @derrabauke @adfinisbot