Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): finish renaming helm-unittest #1069

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(ci): finish renaming helm-unittest #1069

merged 1 commit into from
Jul 12, 2023

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Jul 12, 2023 •
edited
Loading

Description

Hopefully this fixes the weird issues we've seeing with helm unittest lately.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2023
@hairmare hairmare marked this pull request as ready for review July 12, 2023 12:07
@hairmare hairmare requested a review from a team as a code owner July 12, 2023 12:07
@hairmare hairmare requested review from eyenx and luk43 July 12, 2023 12:07
janaurka
janaurka approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@janaurka janaurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@hairmare hairmare merged commit e2102f0 into adfinis:main Jul 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaurka janaurka janaurka approved these changes

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner automatically assigned from adfinis/helm-charts

@luk43 luk43 Awaiting requested review from luk43 luk43 is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairmare @janaurka