Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(keycloak-operator): proper indenting for podTemplate and additionalOptions #1103

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix(keycloak-operator): proper indenting for podTemplate and additionalOptions #1103

merged 1 commit into from
Oct 3, 2023

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Oct 3, 2023 •
edited
Loading

Description

I found some more values for the keycloak operand that we didn't properly indent when creating the chart.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 3, 2023
@hairmare hairmare marked this pull request as ready for review October 3, 2023 11:50
@hairmare hairmare requested a review from a team as a code owner October 3, 2023 11:50
@hairmare hairmare changed the title fix(keycloak-operator): proper indenting for podTemplate and addition… fix(keycloak-operator): proper indenting for podTemplate and additionalOptions Oct 3, 2023
@hairmare hairmare merged commit e532335 into adfinis:main Oct 3, 2023
3 checks passed
@hairmare hairmare deleted the fix/keycloak-operator/more-indent-errors branch October 3, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaillot vmaillot vmaillot approved these changes

@luk43 luk43 Awaiting requested review from luk43 luk43 is a code owner automatically assigned from adfinis/helm-charts

@isantospardo isantospardo Awaiting requested review from isantospardo isantospardo is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairmare @vmaillot