Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kubernetes-etcd-backup): Allow affinity and existing claims #1289

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat(kubernetes-etcd-backup): Allow affinity and existing claims #1289

merged 1 commit into from
Jul 24, 2024

Conversation

4censord
Copy link
Contributor

@4censord 4censord commented Jul 24, 2024 •
edited
Loading

Description

This allows to configure existingClaim as storage and affinity for the kubernetes-etcd-backup chart.

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 24, 2024
@4censord 4censord marked this pull request as ready for review July 24, 2024 07:33
@4censord 4censord requested a review from a team as a code owner July 24, 2024 07:33
@4censord 4censord merged commit 4401e98 into main Jul 24, 2024
3 checks passed
@4censord 4censord deleted the k-etc-backup-impovements branch July 24, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare left review comments

@vmaillot vmaillot vmaillot approved these changes

@maxthier maxthier Awaiting requested review from maxthier maxthier is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4censord @hairmare @vmaillot