Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes-etcd-backup): skip tls verify #1292

Merged
merged 5 commits into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions charts/kubernetes-etcd-backup/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v2
name: kubernetes-etcd-backup
description: Chart for kubernetes-etcd-backup solution
type: application
version: 1.2.0
version: 1.3.0
appVersion: v1.0.6
keywords:
- kubernetes-etcd-backup
Expand All @@ -20,4 +20,4 @@ maintainers:
annotations:
artifacthub.io/changes: |
- kind: changed
description: "Allow configuration of extraVolume/Mounts"
description: "Add insecureSkipTlsVerify flag"
5 changes: 3 additions & 2 deletions charts/kubernetes-etcd-backup/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions charts/kubernetes-etcd-backup/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ data:
ETCD_BACKUP_KEEP_COUNT: {{ .Values.backup.keepcount | quote }}
ETCD_BACKUP_UMASK: {{ .Values.backup.umask | quote }}
ENDPOINT: {{ .Values.etcdConfiguration.endpoint | quote }}
{{- if .Values.etcdConfiguration.insecureSkipTlsVerify }}
ETCDCTL_INSECURE_SKIP_TLS_VERIFY: "true"
{{- end }}
8 changes: 8 additions & 0 deletions charts/kubernetes-etcd-backup/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,15 @@ backup:

etcdConfiguration:
# -- Etcd endpoint ip or hostname without protocol or port
# Example: etcd.kube-system.svc.cluster.local
endpoint: "changeme"
# -- Skip server certificate verification
# Useful for scenarios where etcd nodes are external endpoints (access
# through etcd service in kube-system namespace) and have a different CN/SAN
# in the certificate . Otherwise, "failed to verify certificate: x509:
# certificate is valid for etcd-2, etc., not
# etcd.kube-system.svc.cluster.local"
insecureSkipTlsVerify: false

in0rdr marked this conversation as resolved.
Show resolved Hide resolved
etcdCertification:
# -- etcd-peer-tls secret name
Expand Down