Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thanos): complete removalafter 12 months of being deprecated in the charts #1294

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

eyenx
Copy link
Member

@eyenx eyenx commented Aug 8, 2024

Description

Thanos was flagged as DEPRECATED and fail to template 1 year ago.

According to argocd-app-of-apps.md we can remove it completetly from the repo.

Related to #1073

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@eyenx eyenx requested a review from a team as a code owner August 8, 2024 12:15
@eyenx eyenx requested review from hairmare and maxthier August 8, 2024 12:15
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2024
@eyenx eyenx enabled auto-merge (squash) August 8, 2024 12:19
@eyenx eyenx merged commit 74e1a12 into main Aug 8, 2024
3 checks passed
@eyenx eyenx deleted the feat/remove-thanos branch August 8, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants