Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(huawei-csi-plugin): remove unmaintained chart #766

Merged
merged 1 commit into from
Aug 4, 2022
Merged

chore(huawei-csi-plugin): remove unmaintained chart #766

merged 1 commit into from
Aug 4, 2022

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Aug 4, 2022 •
edited
Loading

Description

We've decided not to maintain this a while ago and it's only still here because of an attempt to silence it's artifacthub warnings.

I'm also preparing a gh-pages PR to completely remove it from our index as well.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 4, 2022
@hairmare hairmare mentioned this pull request Aug 4, 2022
Merged
6 tasks
@hairmare hairmare marked this pull request as ready for review August 4, 2022 16:29
@hairmare hairmare requested review from a team and tongpu as code owners August 4, 2022 16:29
@hairmare hairmare requested review from vmaillot and removed request for a team August 4, 2022 16:29
eyenx
eyenx approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your blood github contibutions are getting better

@hairmare hairmare enabled auto-merge (squash) August 4, 2022 18:47
@hairmare hairmare merged commit 5e23677 into adfinis:main Aug 4, 2022
@hairmare hairmare deleted the chore/rm-huawei-csi branch August 8, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyenx eyenx eyenx approved these changes

@tongpu tongpu Awaiting requested review from tongpu

@vmaillot vmaillot Awaiting requested review from vmaillot vmaillot is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairmare @eyenx