feat(): Add support for s3 storage in Kubernetes etcd backup job #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbertgruszka
changed the title
vmaillot
reviewed
Nov 26, 2024
| mv /tmp/etcd-backup/* "${BACKUP_PATH_POD}" | ||
| rm -rv /tmp/etcd-backup | ||
|
|
||
| # expire backup |
There was a problem hiding this comment.
Do we want to manage the removal of old backups in there too with mc maybe? Then we would not need of a retention policy, what do you think?
There was a problem hiding this comment.
I don't know, I mostly focused on the first if statement, which publishes to s3. This part is responsible for nfs backups.
This part is edited, because I had to format it and that's all
There was a problem hiding this comment.
Right, well we could add that later if needed, so for now I suggest we are fine! Let's merge and test this then :)
vmaillot
approved these changes
Nov 27, 2024
Xelef2000
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for s3 storage in Kubernetes etcd backup job
Issues
#22
Checklist