Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): change commit message prefix for docker update to fix #94

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

tongpu
Copy link
Member

@tongpu tongpu commented Oct 3, 2024

Because I accidentally pushed a feature release today I thought it might be a good idea to change the default prefix from feat to fix, because most of the package updates in the base image are not really relevant for us.

@tongpu tongpu requested review from hairmare and eyenx October 3, 2024 07:21
@tongpu tongpu self-assigned this Oct 3, 2024
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chore: would have also been fine

@tongpu
Copy link
Member Author

tongpu commented Oct 3, 2024

chore: would have also been fine

Yeah, but then an update of the base image would not trigger a release and we would have to decide which base images updates warrant a release. My vision going forward is that I'm not going to merge every single dependabot PR and reject some with a short comment of "package updates not relevant for our use-case".

@tongpu tongpu merged commit 46db279 into main Oct 3, 2024
2 checks passed
@tongpu tongpu deleted the chore/change_dependabot_docker_prefix branch October 3, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants