This repository has been archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
fix: update report billed flag to be like project billed flag #988
Open
MitanOmar
wants to merge
1
commit into
adfinis:main
Choose a base branch
from
MitanOmar:update-report-billed-flag-to-be-like-project-billed-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: update report billed flag to be like project billed flag #988
MitanOmar
wants to merge
1
commit into
adfinis:main
from
MitanOmar:update-report-billed-flag-to-be-like-project-billed-flag
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix adfinis/timed#72 |
MitanOmar
force-pushed
the
update-report-billed-flag-to-be-like-project-billed-flag
branch
from
February 29, 2024 15:54
2baa0f5
to
eba561e
Compare
c0rydoras
suggested changes
Apr 12, 2024
@@ -267,8 +267,7 @@ def bulk(self, request): | |||
if "task" in fields: | |||
# unreject report if task has changed | |||
fields["rejected"] = False | |||
if fields["task"].project.billed: | |||
fields["billed"] = fields["task"].project.billed | |||
fields["billed"] = True if fields["task"].project.billed else False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
fields["billed"] = True if fields["task"].project.billed else False | |
fields["billed"] = fields["task"].project.billed |
this should also work since its a boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0rydoras that's where this started off at #988 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fields["billed"] = bool(fields["task"].project.billed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it isn't a boolean this accomplishes the same
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.