Start beep on freeswitch #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -220,10 +220,9 @@ module Component | |||
| let(:command_options) { { :start_beep => true } } | |||
|
|
|||
| it "should return an error and not execute any actions" do | |||
There was a problem hiding this comment.
You should give this spec a sensible description. You should also assert that the beep happened in this case, and does not happen when start_beep: false.
|
Thanks for this. Just a few more issues that need to be addressed before a merge. Once this is all done, I'd like to see the commits squashed, also :) Thanks for your effort on this 👍 |
|
I'm going to close this since it never met the merge requirements and has been thoroughly superseded by mod_rayo :) See #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #154, support for start_beep is missing on Freeswitch platform.
PS: Recreated pull-request on fresh branch, and added missing specs.