Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix the build on 3.0 #46

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Commits on Aug 24, 2019

  1. Configuration menu
    Copy the full SHA
    0b1b94c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a9d85a5 View commit details
    Browse the repository at this point in the history
  3. [CI] Test more Rubies

    sfgeorge committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    2777ef3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3dbea15 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. [CI] Relax Bundler development dependency.

    Should get things passing on:
    - ruby-2.5.3
    - jruby-9.1.17.0
    sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    4691580 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a48e29 View commit details
    Browse the repository at this point in the history
  3. We don't use EventMachine

    benlangfeld authored and sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    c48b5a5 View commit details
    Browse the repository at this point in the history
  4. Bump copyright year

    benlangfeld authored and sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    6581059 View commit details
    Browse the repository at this point in the history
  5. Typo

    benlangfeld authored and sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    c987ee9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48da9cd View commit details
    Browse the repository at this point in the history
  7. [SPEC] Use simplified assertions from commit: "Make Stream usable in …

    …a supervision tree"
    
    See d9b806a
    benlangfeld authored and sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    f312242 View commit details
    Browse the repository at this point in the history
  8. We don't support Celluloid 0.17 yet

    benlangfeld authored and sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    937ef57 View commit details
    Browse the repository at this point in the history
  9. Avoid rspec deprecations

    benlangfeld authored and sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    5c03334 View commit details
    Browse the repository at this point in the history
  10. Missed some RSpec deprecations

    benlangfeld authored and sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    39625ca View commit details
    Browse the repository at this point in the history
  11. [SPEC] Don't error on RSpec deprecations.

    Makes it easier to ensure that the build stays green from the RSpec 2.99 -> RSpec 3.x transition.
    sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    ece2346 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7aecd91 View commit details
    Browse the repository at this point in the history
  13. Convert specs to RSpec 2.99.2 syntax with Transpec

    This conversion is done by Transpec 3.4.0 with the following command:
        transpec -f
    
    * 65 conversions
        from: obj.should
          to: expect(obj).to
    
    * 51 conversions
        from: == expected
          to: eq(expected)
    
    * 8 conversions
        from: it { should ... }
          to: it { is_expected.to ... }
    
    * 6 conversions
        from: obj.should_not
          to: expect(obj).not_to
    
    * 5 conversions
        from: =~ /pattern/
          to: match(/pattern/)
    
    * 5 conversions
        from: it { should_not ... }
          to: it { is_expected.not_to ... }
    
    * 3 conversions
        from: obj.should_receive(:message)
          to: expect(obj).to receive(:message)
    
    * 2 conversions
        from: be_false
          to: be_falsey
    
    * 2 conversions
        from: its(:attr) { }
          to: describe '#attr' do subject { super().attr }; it { } end
    
    * 1 conversion
        from: lambda { }.should
          to: expect { }.to
    
    * 1 conversion
        from: mock('something')
          to: double('something')
    
    * 1 conversion
        from: obj.stub(:message)
          to: allow(obj).to receive(:message)
    
    * 1 conversion
        from: pending
          to: skip
    
    For more details: https://github.com/yujinakayama/transpec#supported-conversions
    sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    976e90f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6f33506 View commit details
    Browse the repository at this point in the history
  15. [SPEC] Replace undocumented, unsupported "feature" of #with

    ...with a documented, supported argument matcher block to #receive.
    
    Unsupported in #with:
    rspec/rspec-mocks#377 (comment)
    
    Supported in #receive:
    https://github.com/rspec/rspec-mocks#arbitrary-handling
    sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    afd95f3 View commit details
    Browse the repository at this point in the history
  16. [SPEC] Upgrade to RSpec 3.x

    sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    2f41c09 View commit details
    Browse the repository at this point in the history
  17. [SPEC] Run transpec one more time to fix deprecations

    Convert specs to RSpec 3.8.2 syntax with Transpec
    
    This conversion is done by Transpec 3.4.0 with the following command:
        transpec -f
    
    * 2 conversions
        from: obj.stub(:message => value)
          to: allow(obj).to receive_messages(:message => value)
    
    For more details: https://github.com/yujinakayama/transpec#supported-conversions
    sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    ab343b6 View commit details
    Browse the repository at this point in the history
  18. Revert "Use rake < 11.x until we upgrade RSpec past 2.x"

    This reverts commit a9d85a5.
    sfgeorge committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    c55ec91 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    fc812fc View commit details
    Browse the repository at this point in the history