Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gnome 42 dark mode #91

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wmcmillian-coalmarch
Copy link

This adds support for gnome 42's new dark mode. So that the wall paper changes even if it is in dark mode.

@gw8ndal
Copy link

gw8ndal commented Apr 28, 2022

Looks good, I would love to see it merged

@DonFruendo
Copy link

+1 for this. With more people using dark mode and Gnome dedicating a setting to it, this is a really good addition!

@HaydenS3
Copy link

HaydenS3 commented Jul 8, 2022

Works but creates a file with $1 as name on Ubuntu 22.04. Removing the 2>$1 from scripts fixed the issue.

Copy link

@vintagefuture vintagefuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to replace 2>$1 with 2>/dev/null
Otherwise an empty file called -c might be generated.

vintagefuture

This comment was marked as duplicate.

@adi1090x
Copy link
Owner

Sorry for being way too late.

Nice PR, can you resolve conflicts and reproduce it?

@adi1090x adi1090x closed this Aug 22, 2023
@adi1090x adi1090x reopened this Aug 22, 2023
@vintagefuture
Copy link

@wmcmillian-coalmarch Are you able to resolve the conflict?
@adi1090x I'm happy to submit a new PR with these same changes if it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants