Fix sd-dynamic-prompts error with empty prompts #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested changes
Jan 13, 2025
Comment on lines
71
to
72
| if gen: | ||
| prompts.append(str(next(iter(gen)))) |
There was a problem hiding this comment.
Why bother looking at if gen: inside the loop? If there are 10,000 seeds, this will end up just seeding the generator 10,000 times and do nothing with it.
It looks like gen = self._context.sample_prompts(template, num_images) should be before if seeds:, and if not gen: return [] after it.
The non-seeds branch should then also use the same gen: return [str(p) for p in gen].
|
@akx you have right! gen check outside the loop it's much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolved the sd-dynamic-prompt issue 513 adieyal/sd-dynamic-prompts#513