Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Dictionary ID #387

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Add support for Dictionary ID #387

merged 3 commits into from
Jan 22, 2025

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Jan 7, 2025 •
edited
Loading

Closes #389

Changes

  • Update adiwg-mdcodes and adiwg-mdjson_schemas dependencies to version 2.10.1
  • Update Gemfile.lock
  • Add support to mdJson reader
  • Add support to mdJson writer
  • Increment beta version
  • Add dictionaryId to the test helper object

FAILING TESTS

The tests that are failing are regarding the acquisitions schema that was added. There is another PR to add that functionality which will fix those tests. Let's not worry about them here.

@jwaspin jwaspin marked this pull request as ready for review January 21, 2025 22:43
@jwaspin jwaspin changed the title Upgrade mdToolkit Dependencies Add support for Dictionary ID Jan 21, 2025
@jwaspin jwaspin requested a review from hmaier-fws January 21, 2025 22:47
@hmaier-fws hmaier-fws merged commit c5d379a into develop Jan 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaier-fws hmaier-fws Awaiting requested review from hmaier-fws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Dictionary ID
2 participants
@jwaspin @hmaier-fws