-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions support #66
Open
zilder
wants to merge
17
commits into
adjust:master
Choose a base branch
from
zilder:pluggable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `load_module` function that dynamically opens shared object and calls special `schaufel_module_init` func; * Create `contrib` directory for modules and a Makefile to build modules in the directory; * Extracted postgres module to `contrib` directory and added a Makefile to build it as a shared library.
… that print include path and library path and make use of those to build contribs and extensions
autogenerated headers and update .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for extensions implemented as shared libraries. External modules must implement the interface provided by
modules.h
and register themselves withregister_module()
function. A single library can register multiple modules.Some of existing modules (those that depend on other libraries) were moved to
contrib
directory and were provided with its own Makefiles. Contrib modules and extensions should includecontrib.mk
which incorporates all necessary targets for building and installing modules.Top level
Makefile
has been splitted into to parts:Makefile
itself andMakefile.global
. The latter contains common variables useful for bothMakefile
andcontrib.mk
. After installation theMakefile.global
andcontrib.mk
file are located inschaufel
's libraries path.Added
-L
(library path) and-I
(include path) options toschaufel
executable. Those are needed bycontrib.mk
to provide correct include path to a compiler and to install modules.Also
autoconf
script has been added. It checks for compiler options, shared libraries needed byschaufel
to build, generates makefiles andbuild.h
header file.