Refactor & CI #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d map loops, objectTypes switch instead of if-else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
For my final MSc thesis, I want to build a xAPI library in order to configure any web application to listen to different events and send the statements created to an LRS. It is inspired by the xAPI YouTube library. I want to use the validator in the project, and I found useful to refactor it. This is only due to the fact that this project is 4 years old and I thought it would be nice to have it written in ES6. I still want to make some changes, but I think it is a good point to start from. I also included Travis CI to check if all the tests are passing.
Any feedback is very welcome :)
Thanks!!