Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
there's a bug when
Deserialize
-ing a struct that contains anOption
as one of its fields. We use this viarosrust
to query a substructure of interrelated configuration parameters in a typed manner.Example to reproduce:
Load this YAML file as rosparams (
rosparam load params.yaml
):Then
cargo run
it. With the current git main branch of xml-rpc-rs, we getWith this patch, we get:
Note that
Option
now behaves as expected for theSome
case as well as theNone
case (the latter did work already before).