#121 Fix handling of V4 signed requests that don't use chunking. #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was that the code incorrectly assumed that anything signed with a V4 SHA signature is also using the V4 chunked encoding. That's fixed now, and a test was added to check uploading a file with all combinations of signing and chunking enabled/disabled.
Related Issue
Fixes #107, fixes #121, fixes #147.
Tasks