Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included "Relevance" as one of the sort option #714

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sambasivaraj
Copy link

Included "Relevance" as one of the sort option since there are no option to extend the SearchOptions class and modified as per the Project need

Description

ProductListImpl (com.adobe.cq.commerce.core.components.internal.models.v1.productlist) has been modified to include an additional option of sort by relevance and the required test classes are modified .

Related Issue

Its a new feature that need to be added to support project need and also it has been discussed with Marcus

Motivation and Context

Add this option will help the project team to leverage the sort by relevance option in the Product List component

How Has This Been Tested?

Code has been locally deployed to AEM Cloud SDK and validated the product list component

Screenshots (if appropriate):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have signed the Adobe Open Source CLA.x
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. x
  • I have added tests to cover my changes and the overall coverage did not decrease. x
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.x

@sambasivaraj sambasivaraj changed the title Feature/relevance sort option Included "Relevance" as one of the sort option Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #714 (9b02523) into master (f8bf32c) will decrease coverage by 1.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #714      +/-   ##
============================================
- Coverage     88.21%   86.99%   -1.23%     
============================================
  Files           287      151     -136     
  Lines          7223     3152    -4071     
  Branches       1058      518     -540     
============================================
- Hits           6372     2742    -3630     
+ Misses          637      410     -227     
+ Partials        214        0     -214     
Flag Coverage Δ
jest 85.92% <ø> (ø)
karma 89.95% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/internal/models/v1/product/ProductRetriever.java
...ontcontext/SearchResultsStorefrontContextImpl.java
.../internal/servlets/ProductPageRedirectServlet.java
...e/core/components/storefrontcontext/QueryType.java
...s/internal/models/v1/common/TitleTypeProvider.java
...ervices/ComponentsConfigurationAdapterFactory.java
...ch/internal/services/SearchResultsServiceImpl.java
...nal/storefrontcontext/SearchResultProductImpl.java
...s/internal/models/v1/button/CategoryRetriever.java
...al/models/v1/categorylist/CategoriesRetriever.java
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8bf32c...9b02523. Read the comment docs.

@mhaack
Copy link
Contributor

mhaack commented Oct 8, 2021

@sambasivaraj the PR LGTM but can you sign the Adobe Open Source CLA. Thx.

@mhaack mhaack requested review from herzog31, LSantha, buuhuu and laurentiumagureanu and removed request for herzog31 October 8, 2021 07:43
@mhaack mhaack added the enhancement New feature or request label Oct 8, 2021
@herzog31 herzog31 removed their request for review March 23, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants